[webkit-reviews] review denied: [Bug 90218] IDL overloads should not treat wrapper types as nullable by default : [Attachment 150254] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 90218: IDL overloads should not treat wrapper types as nullable by default
https://bugs.webkit.org/show_bug.cgi?id=90218

Attachment 150254: Patch
https://bugs.webkit.org/attachment.cgi?id=150254&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150254&action=review


Supporting '?' definitely looks like a progression! The approach looks great to
me. Marking r- due to missing test cases.

> Verified with some grepping and before/after run of the code generator w/
Chromium/V8 - a JSC run probably wouldn't hurt, but let's see what the bots
say.

Please doubly confirm that all generated code has 0 diff both in JSC and in V8.


> Source/WebCore/ChangeLog:7
> +

Please explain what this patch is doing.

> Source/WebCore/ChangeLog:8
> +	   No new tests - no behavioral changes.

Please add test cases for '?' to TestObj.idl