[webkit-reviews] review granted: [Bug 77513] webkit-perf.appspot.com should accept test results without medians : [Attachment 124889] fixes the bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 31 23:44:01 PST 2012
MORITA Hajime <morrita at google.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 77513: webkit-perf.appspot.com should accept test results without medians
https://bugs.webkit.org/show_bug.cgi?id=77513
Attachment 124889: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=124889&action=review
------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124889&action=review
r=me. Sometime we should have test for this.
> Websites/webkit-perf.appspot.com/report_handler.py:99
> + TestResult(name=test_name, build=build,
value=float(result['avg']), valueMedian=_float_or_none(result, 'median'),
Considering TestResult.value is required field, this change looks reasonable.
More information about the webkit-reviews
mailing list