[webkit-reviews] review granted: [Bug 77231] HTMLPreloadScanner should understand the <base> element : [Attachment 124848] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 77231: HTMLPreloadScanner should understand the <base> element
https://bugs.webkit.org/show_bug.cgi?id=77231

Attachment 124848: Patch
https://bugs.webkit.org/attachment.cgi?id=124848&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124848&action=review


LGTM.

> Source/WebCore/ChangeLog:9
> +	   preloadnig resources.  If there was a <base> tag, this could cause
the

ah preloadnig!

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:219
> +    // The first baseElementURL is the one that counts.

You probably want to say the first <base> element wins.