[webkit-reviews] review granted: [Bug 77487] Make js-test-pre.js more worker friendly : [Attachment 124840] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 77487: Make js-test-pre.js more worker friendly
https://bugs.webkit.org/show_bug.cgi?id=77487

Attachment 124840: Patch
https://bugs.webkit.org/attachment.cgi?id=124840&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124840&action=review


> LayoutTests/fast/js/resources/js-test-pre.js:3
> +if (!isWorker() && window.layoutTestController)
>      layoutTestController.dumpAsText(window.enablePixelTesting);

Why not just use self.layoutTestController and self.enablePixelTesting? Then
you don't need to check or move isWorker. Similarly, can you change all uses of
window in this file to self for consistency?