[webkit-reviews] review granted: [Bug 77248] run-webkit-tests calls out to webkit-build-directory twice : [Attachment 124839] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 16:20:14 PST 2012


Dirk Pranke <dpranke at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 77248: run-webkit-tests calls out to webkit-build-directory twice
https://bugs.webkit.org/show_bug.cgi?id=77248

Attachment 124839: Patch
https://bugs.webkit.org/attachment.cgi?id=124839&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124839&action=review


> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:383
> +	       # Set --root here Since this modifies the options object used by
the worker subprocesses,

Nit: fix the comment. Looks fine otherwise.


More information about the webkit-reviews mailing list