[webkit-reviews] review denied: [Bug 76035] Add state attribute to history's dom interface. : [Attachment 124811] First attempt at a full proper solution

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 76035: Add state attribute to history's dom interface.
https://bugs.webkit.org/show_bug.cgi?id=76035

Attachment 124811: First attempt at a full proper solution
https://bugs.webkit.org/attachment.cgi?id=124811&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124811&action=review


r- due to removed PopStateEvent constructor.

It is good to show the whole image of your intended change, but it might be
better to split the big patch into sub-patches for review, so that each
sub-patch is small enough to confirm that it is correct.

> Source/WebCore/dom/PopStateEvent.idl:31
> +	   readonly attribute [CustomGetter] DOMObject state;

Why did you remove [ConstructorTemplate=Event] and [InitializedByConstructor]?
Then I am afraid that "new PopStateEvent()" wouldn't work.