[webkit-reviews] review requested: [Bug 76647] StringProtoFuncToUpperCase should call StringImpl::upper similar to StringProtoToLowerCase : [Attachment 124834] Updated patch with fix for s-sharp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 15:26:11 PST 2012


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 76647: StringProtoFuncToUpperCase should call StringImpl::upper similar to
StringProtoToLowerCase
https://bugs.webkit.org/show_bug.cgi?id=76647

Attachment 124834: Updated patch with fix for s-sharp
https://bugs.webkit.org/attachment.cgi?id=124834&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
This patch is performance neutral on sunspider, v8 and kraken.	It speeds up
the dromaeo-object-string toUpperCase subtest from 238runs/sec to 347runs/sec
(46%).	Unfortunately, this provides little benefit to the dromaeo javascript
overall.


More information about the webkit-reviews mailing list