[webkit-reviews] review denied: [Bug 72294] Add contains() test to Region : [Attachment 124767] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied  review:
Bug 72294: Add contains() test to Region
https://bugs.webkit.org/show_bug.cgi?id=72294

Attachment 124767: Patch
https://bugs.webkit.org/attachment.cgi?id=124767&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124767&action=review


> Source/WebCore/platform/graphics/Region.cpp:70
> +    return WebCore::intersect(region, *this).m_shape == region.m_shape;

If you want to, you can add a Region::operator== that checks the bounds rect as
well as the shape - that might be useful for other purposes as well.

> Source/WebCore/platform/graphics/Region.h:149
> +inline bool operator==(const Region::Span& a, const Region::Span& b) {
return a.y == b.y && a.segmentIndex == b.segmentIndex; }
> +inline bool operator==(const Region::Shape& a, const Region::Shape& b) {
return a.m_spans == b.m_spans && a.m_segments == b.m_segments; }
> +

According to our style guidelines, the { should be on a new line.