[webkit-reviews] review granted: [Bug 49543] [GTK] Improve FrameLoader signals. Resource loading : [Attachment 124721] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 31 13:43:35 PST 2012
Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 49543: [GTK] Improve FrameLoader signals. Resource loading
https://bugs.webkit.org/show_bug.cgi?id=49543
Attachment 124721: Patch
https://bugs.webkit.org/attachment.cgi?id=124721&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124721&action=review
Okay. Thanks!
> Source/WebKit/gtk/webkit/webkitwebframe.cpp:344
> + (GSignalFlags)(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION),
Please use static_cast here.
> Source/WebKit/gtk/webkit/webkitwebframe.cpp:365
> + (GSignalFlags)(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION),
Ditto.
> Source/WebKit/gtk/webkit/webkitwebframe.cpp:384
> + (GSignalFlags)(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION),
Ditto and for the rest of the patch.
More information about the webkit-reviews
mailing list