[webkit-reviews] review denied: [Bug 69210] CSS 2.1 failure: inline-box-002.htm fails : [Attachment 124804] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 69210: CSS 2.1 failure: inline-box-002.htm fails
https://bugs.webkit.org/show_bug.cgi?id=69210

Attachment 124804: Patch
https://bugs.webkit.org/attachment.cgi?id=124804&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
There's one more issue that I see here,  and it's that the relative positioning
information will be lost if the anonymous block has it style changed via some
other mechanism. Basically RenderBlock::styleDidChange needs to ask if
(isAnonymousBlockContinuation()) and make sure the newStyle preserves the
position of the oldStyle.

Here is a test case. Add height/width/whatever to make it all visible:

<div style="color:red"><span style="position:relative">Hello
<div>Block</div></span></div>

If you alter the outermost div's background color from red to green, the
anonymous block continuation is going to update its style. At that point it
will lose the knowledge that it needed to be relatively positioned. You
basically just have to preserve that across the change from oldStyle to
newStyle.