[webkit-reviews] review granted: [Bug 76683] IndexedDB: refactor basics layout test so that it can be run on workers. : [Attachment 124422] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 76683: IndexedDB: refactor basics layout test so that it can be run on
workers.
https://bugs.webkit.org/show_bug.cgi?id=76683

Attachment 124422: Patch
https://bugs.webkit.org/attachment.cgi?id=124422&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124422&action=review


LGTM

>>> LayoutTests/storage/indexeddb/resources/basics.js:2
>>> +	 // FIXME: Change js-test-pre.js to use self in place of window where
>> 
>> Should this file go in resources or script-tests?  If this file is only used
by basics.html, then it probably should go in script-tests.
> 
> Also in basics-workers.html.	Should I still put it in script-tests?	I
thought script-tests/make-script-test-wrappers was obsolete for tests outside
of fast/js.

Ah, you can keep it here since it's used by 2 files.