[webkit-reviews] review denied: [Bug 77149] WebGL conformance test misc/functions-returning-strings.html fails : [Attachment 124741] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Ehsan Akhgari [:ehsan]
<ehsan at mozilla.com>'s request for review:
Bug 77149: WebGL conformance test misc/functions-returning-strings.html fails
https://bugs.webkit.org/show_bug.cgi?id=77149

Attachment 124741: Patch
https://bugs.webkit.org/attachment.cgi?id=124741&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124741&action=review


Looks good overall; r- for a couple of relatively minor issues. Unfortunately I
don't think it's possible to get the full test logs off the EWS bots; if you
haven't already, build DumpRenderTree in your Chromium workspace and use
src/webkit/tools/layout_tests/run_webkit_tests.sh to check the expected
results. I'm doing this now and will update this bug if anything turns up.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:5125
> +	 return WTF::emptyString();

4 space indent. (Style queue should have caught this.)

> Tools/ChangeLog:5
> +	   https://bugs.webkit.org/show_bug.cgi?id=77149

Please split this change off into a second bug.