[webkit-reviews] review granted: [Bug 77453] [chromium] Expose windowResizerRectChanged() on WebWidget. : [Attachment 124771] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 10:45:21 PST 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Nico Weber
<thakis at chromium.org>'s request for review:
Bug 77453: [chromium] Expose windowResizerRectChanged() on WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=77453

Attachment 124771: Patch
https://bugs.webkit.org/attachment.cgi?id=124771&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124771&action=review


R=me

> Source/WebKit/chromium/public/WebWidget.h:188
> +    virtual void windowResizerRectChanged() { }

nit: please name this didChangeWindowResizerRect() to match naming conventions
in the API.


More information about the webkit-reviews mailing list