[webkit-reviews] review denied: [Bug 60010] [Chromium]Add clear_autofill flag to hide autofill popup without clear field. : [Attachment 92677] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 09:54:55 PST 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 60010: [Chromium]Add clear_autofill flag to hide autofill popup without
clear field.
https://bugs.webkit.org/show_bug.cgi?id=60010

Attachment 92677: Patch
https://bugs.webkit.org/attachment.cgi?id=92677&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=92677&action=review

>> Source/WebKit/chromium/public/WebView.h:301
>> +	virtual void acceptCurrectAutoFilled() = 0;
> 
> nit: Is there any reason not to name this more generally, e.g. """
acceptSelectedPopupItem() """ ?

Agreed, the name is wrong.  At the very least, it seems like you probably meant
to write "Current" instead of "Currect", but I like Ilya's suggestion.


More information about the webkit-reviews mailing list