[webkit-reviews] review granted: [Bug 77289] Web Inspector: CodeGeneratorInspector.py: reimplement generated array types : [Attachment 124614] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 06:59:37 PST 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 77289: Web Inspector: CodeGeneratorInspector.py: reimplement generated
array types
https://bugs.webkit.org/show_bug.cgi?id=77289

Attachment 124614: Patch
https://bugs.webkit.org/attachment.cgi?id=124614&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124614&action=review


> Source/WebCore/inspector/CodeGeneratorInspector.py:1712
> +

Extra line.

> Source/WebCore/inspector/CodeGeneratorInspector.py:2204
> +    for (unsigned i = 0; i < array->length(); i++) {

Please remove braces.


More information about the webkit-reviews mailing list