[webkit-reviews] review granted: [Bug 77421] Parent SVGFontFaceElements style declaration to the rule : [Attachment 124702] patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 77421: Parent SVGFontFaceElements style declaration to the rule
https://bugs.webkit.org/show_bug.cgi?id=77421

Attachment 124702: patch
https://bugs.webkit.org/attachment.cgi?id=124702&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124702&action=review


> Source/WebCore/css/CSSFontFaceRule.cpp:36
> -    // FIXME: SVGFontFaceElement's style declaration should probably be
parented to the rule too.
> -    if (m_style && !m_style->isElementStyleDeclaration())
> -	   m_style->clearParentRule();
> +    m_style->clearParentRule();

Why do we now know m_style cannot be null? You should explain in the ChangeLog.