[webkit-reviews] review denied: [Bug 77382] [Windows] Add API to enable inverted color drawing on a WebView : [Attachment 124630] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Andy Estes
<aestes at apple.com>'s request for review:
Bug 77382: [Windows] Add API to enable inverted color drawing on a WebView
https://bugs.webkit.org/show_bug.cgi?id=77382

Attachment 124630: Patch
https://bugs.webkit.org/attachment.cgi?id=124630&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124630&action=review


Can you add pixel tests for this? We should test both the accelerated and
non-accelerated cases.

> Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:280
> +void CACFLayerTreeHost::setShouldInvertColors(bool shouldInvertColors)
> +{
> +    UNUSED_PARAM(shouldInvertColors);
> +}

I think it would be clearer to put the parameter name in the header file and
omit it here.