[webkit-reviews] review denied: [Bug 74519] [Qt] Automatic clean build feature always do clean build with --no-webkit2 : [Attachment 124683] Patch: features.prf

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Nandor Huszka
<Huszka.Nandor at stud.u-szeged.hu>'s request for review:
Bug 74519: [Qt] Automatic clean build feature always do clean build with
--no-webkit2
https://bugs.webkit.org/show_bug.cgi?id=74519

Attachment 124683: Patch: features.prf 
https://bugs.webkit.org/attachment.cgi?id=124683&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124683&action=review


> Tools/qmake/mkspecs/features/features.prf:113
> +# --no-webkit2 build did not contain this define, but it needs to avoid
unwanted clean builds by other scripts

"it's needed"

> Tools/qmake/mkspecs/features/features.prf:115
> +no_webkit2:!contains(DEFINES, PLUGIN_ARCHITECTURE_UNSUPPORTED): {

I'd write this (along with the lines below) as

!contains(DEFINES, PLUGIN_ARCHITECTURE_UNSUPPORTED) {
    no_webkit2 {
	# --no-webkit2 build did not contain this define, but it's needed to
avoid unwanted clean builds by other scripts
	DEFINES += PLUGIN_ARCHITECTURE_UNSUPPORTED=1
    } else {
	# The old block
    }
}