[webkit-reviews] review granted: [Bug 76801] Listboxes incorrectly display contents when cleared and then re-populated : [Attachment 124609] patch3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 00:19:45 PST 2012


Simon Fraser (on vacation until 2-14) <simon.fraser at apple.com> has granted Joe
Thomas <joethomas at motorola.com>'s request for review:
Bug 76801: Listboxes incorrectly display contents when cleared and then
re-populated
https://bugs.webkit.org/show_bug.cgi?id=76801

Attachment 124609: patch3
https://bugs.webkit.org/attachment.cgi?id=124609&action=review

------- Additional Comments from Simon Fraser (on vacation until 2-14)
<simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124609&action=review


> LayoutTests/fast/forms/listbox-clear-restore.html:36
> +function clearTimeout()

There is already a window.clearTimeout(). You should give this a different
name.

> LayoutTests/fast/forms/listbox-clear-restore.html:45
> +    if (window.layoutTestController)
> +	layoutTestController.waitUntilDone();

Bad indentation here.


More information about the webkit-reviews mailing list