[webkit-reviews] review denied: [Bug 77349] Track the NPN protocol version negotiated with the server : [Attachment 124624] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied raman tenneti
<rtenneti at chromium.org>'s request for review:
Bug 77349: Track the NPN protocol version negotiated with the server
https://bugs.webkit.org/show_bug.cgi?id=77349

Attachment 124624: Patch
https://bugs.webkit.org/attachment.cgi?id=124624&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124624&action=review


> Source/WebKit/chromium/public/platform/WebURLResponse.h:151
> +    WEBKIT_EXPORT WebCString protocolVersion() const;

this field and the NpnNegotiated field don't really belong in webkit.  you are
adding
this one here just as plumbing.  the same was true when NpnNegotiated was
added.

since then, we have developed a way to attach opaque extra data to a
WebURLRequest
(and underlying ResourceRequest).  can you use that instead?

see WebURLRequest::setExtraData.

On the chromium side, look at RenderViewImpl::willSendRequest to see where
setExtraData is called.

it would be great if you could move NpnNegotiated too! :-)