[webkit-reviews] review granted: [Bug 77329] [PerformanceTests] Add landing html for Dromaeo dom-query test : [Attachment 124655] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 77329: [PerformanceTests] Add landing html for Dromaeo dom-query test
https://bugs.webkit.org/show_bug.cgi?id=77329

Attachment 124655: Patch
https://bugs.webkit.org/attachment.cgi?id=124655&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124655&action=review


> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:254
> +	   re.compile(r'has \d+ onunload handler')]

Is it possible to make this expression more explicit? We don't want to ignore
random errors appearing on the same line (e.g. due to missing \n)

> PerformanceTests/ChangeLog:16
> +	   * Dromaeo/resources/drtrunner.js: Added.

It's kind of oxymoron to call it drtrunner.js now that this file is inside
PerfomanceTests but I can't think of a better name.