[webkit-reviews] review granted: [Bug 77378] Enable memcache on webkit-perf.appspot.com : [Attachment 124623] Enables memcache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 30 17:32:47 PST 2012


Adam Barth <abarth at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 77378: Enable memcache on webkit-perf.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=77378

Attachment 124623: Enables memcache
https://bugs.webkit.org/attachment.cgi?id=124623&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124623&action=review


Feel free to ignore these style issues.  (If you'd like to ignore them, let me
know and I'll stop randomly flagging them.)

> Websites/webkit-perf.appspot.com/report_handler.py:89
> +	   for testName, result in self._body['results'].iteritems():

testName => test_name

> Websites/webkit-perf.appspot.com/runs_handler.py:64
> +	   cacheKey = Test.cacheKey(testId, branchId, platformId)

cacheKey => cache_key


More information about the webkit-reviews mailing list