[webkit-reviews] review granted: [Bug 77373] REGRESSION (r91935): text-combine fails : [Attachment 124636] Do not use the vertical-glyph getter for horizontal, non-fullwidth glyphs

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 77373: REGRESSION (r91935): text-combine fails
https://bugs.webkit.org/show_bug.cgi?id=77373

Attachment 124636: Do not use the vertical-glyph getter for horizontal,
non-fullwidth glyphs
https://bugs.webkit.org/attachment.cgi?id=124636&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124636&action=review


> Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp:68
> +    } else if ((fontData->platformData().widthVariant() != RegularWidth &&
CTFontGetGlyphsForCharacters(fontData->platformData().ctFont(), buffer,
glyphs.data(), bufferLength))
> +	   || (fontData->platformData().widthVariant() == RegularWidth &&
wkGetVerticalGlyphsForCharacters(fontData->platformData().ctFont(), buffer,
glyphs.data(), bufferLength))) {

I think this should use ? : or an if statement rather than calling widthVariant
twice. Maybe in a helper function.