[webkit-reviews] review granted: [Bug 77336] REGRESSION(r105797): prepare-ChangeLog for a .cpp file can output an empty method name (i.e. "()") : [Attachment 124634] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 77336: REGRESSION(r105797): prepare-ChangeLog for a .cpp file can output an
empty method name (i.e. "()")
https://bugs.webkit.org/show_bug.cgi?id=77336

Attachment 124634: Patch
https://bugs.webkit.org/attachment.cgi?id=124634&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124634&action=review


> Tools/ChangeLog:33
> +	   (generateFunctionLists): As a hack, modified so that
prepare-ChangeLog does not output
> +	   an empty method name. Ideally this should not happen but may happen,
since the
> +	   parsers are not perfect.

I think this is a good idea.