[webkit-reviews] review granted: [Bug 77233] Add ElementAttributeData class to replace internal uses of NamedNodeMap : [Attachment 124576] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 30 15:31:41 PST 2012


Andreas Kling <kling at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 77233: Add ElementAttributeData class to replace internal uses of
NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=77233

Attachment 124576: Patch
https://bugs.webkit.org/attachment.cgi?id=124576&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124576&action=review


r=me, looks like a good place to start. Mac build needs fixing though.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:737
> +		2CF6878A14D32EFF00340F39 /* ElementAttributeData.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 2CF6878914D32EFF00340F39 /*
ElementAttributeData.h */; };

Needs "settings = {ATTRIBUTES = (Private, ); };"


More information about the webkit-reviews mailing list