[webkit-reviews] review granted: [Bug 77357] WebCore build exceeds address space on 32-bit Windows builders (again) : [Attachment 124583] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 77357: WebCore build exceeds address space on 32-bit Windows builders
(again)
https://bugs.webkit.org/show_bug.cgi?id=77357

Attachment 124583: Patch
https://bugs.webkit.org/attachment.cgi?id=124583&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124583&action=review


> Source/WebCore/ChangeLog:9
> +	   Add an Inspector All-In-One file, but only use it in Release and
Production builds to make
> +	   it possible to debug in the Debug configuration (the symbols will be
in the correct .o file

I think you mean .obj, not .o. It's probably worth mentioning that this is
different from our other AllInOne.cpp files, but we think this new way is
better.

> Source/WebCore/inspector/InspectorAllInOne.cpp:2
> + * Copyright (C) 2011 Apple Inc. All rights reserved.

It's 2012!