[webkit-reviews] review denied: [Bug 53733] Timers can fire after a frame has been put into the page cache : [Attachment 124548] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Allan Sandfeld Jensen
<allan.jensen at nokia.com>'s request for review:
Bug 53733: Timers can fire after a frame has been put into the page cache
https://bugs.webkit.org/show_bug.cgi?id=53733

Attachment 124548: Patch
https://bugs.webkit.org/attachment.cgi?id=124548&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124548&action=review


I really don't like the need to have every subclass of ActiveDOMObject call
didInstallActiveDOMObject.  That's not going to scale well.

> Source/WebCore/dom/ScriptExecutionContext.cpp:266
> +void ScriptExecutionContext::didInstallActiveDOMObject(ActiveDOMObject*
object)
> +{
> +    ASSERT(m_activeDOMObjects.contains(object));
> +    // Ensure all ActiveDOMObjects are suspended also newly created ones.
> +    if (m_activeDOMObjectsAreSuspended)
> +	   object->suspend(m_suspendReason);
> +}

Why can't this work be done in didCreateActiveDOMObject ?