[webkit-reviews] review granted: [Bug 77168] [Windows] Optionally invert colors when drawing to a WebView's backing store. : [Attachment 124246] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 30 11:27:43 PST 2012


Sam Weinig <sam at webkit.org> has granted Andy Estes <aestes at apple.com>'s request
for review:
Bug 77168: [Windows] Optionally invert colors when drawing to a WebView's
backing store.
https://bugs.webkit.org/show_bug.cgi?id=77168

Attachment 124246: Patch
https://bugs.webkit.org/attachment.cgi?id=124246&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124246&action=review


You should probably file bugs on other graphics backends to implement
difference.  Especially Cairo, since they use win/WebView.

> Source/WebKit/win/WebView.cpp:335
> +    : m_shouldInvertColors(false)
> +    , m_refCount(0)

I would be good if refCount remained first.


More information about the webkit-reviews mailing list