[webkit-reviews] review granted: [Bug 77263] PlatformScreenMac should not rely on NSWindow for important bits of data : [Attachment 124405] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 77263: PlatformScreenMac should not rely on NSWindow for important bits of
data
https://bugs.webkit.org/show_bug.cgi?id=77263

Attachment 124405: Patch 
https://bugs.webkit.org/attachment.cgi?id=124405&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124405&action=review


r=me

> Source/WebCore/platform/PlatformScreen.h:59
> +    FloatRect toUserSpace(const NSRect&, NSWindow *destination, float
deviceScaleFactor);
> +    NSRect toDeviceSpace(const FloatRect&, NSWindow *source, float
deviceScaleFactor);

Follow-up bug: It looks like these functions will do the wrong thing in WebKit2
in the case of multiple screens where the window is not on the primary screen,
since the NSWindow argument will be NULL.