[webkit-reviews] review granted: [Bug 77051] Layout/floats.html should be runnable by run-perf-tests : [Attachment 124527] Patch V2

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 77051: Layout/floats.html should be runnable by run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=77051

Attachment 124527: Patch V2
https://bugs.webkit.org/attachment.cgi?id=124527&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124527&action=review


> PerformanceTests/ChangeLog:9
> +	   Some tests take longer to run and I've changed the number of
iterations, so that each tests finishes under 1s per run.

Could you split this line into two before landing it? It's really long.

> PerformanceTests/ChangeLog:12
> +	       Moved Math.random to runner.js.

We normally append the comment on the same line as the test name and : with one
space. e.g.
* DOM/resources/dom-perf.js: Moved Math.random to runner.js.

> PerformanceTests/ChangeLog:36
> +	       Moved the Math.random to runner.js to be used by all tests.
> +	       Added resetRandomSeed to bring the randomizer back to initial
seed.
> +	       It is useful to get the same results at every run and minimize
the
> +	       differences between runs.

And when line wraps, we don't normally indent but instead align them to where (
is in (Math.random). (i.e. indented by exactly 8 spaces from the beginning).