[webkit-reviews] review granted: [Bug 77326] Web Inspector: keyboard navigation through comparison view in heap profiler should update retainers view : [Attachment 124538] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 30 08:07:00 PST 2012


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 77326: Web Inspector: keyboard navigation through comparison view in heap
profiler should update retainers view
https://bugs.webkit.org/show_bug.cgi?id=77326

Attachment 124538: Patch
https://bugs.webkit.org/attachment.cgi?id=124538&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124538&action=review


> Source/WebCore/inspector/front-end/DataGrid.js:1473
>	       this.dispatchEventToListeners("selected");

It seems strange that you introduce SelectedNode event beside the "selected"
one.


More information about the webkit-reviews mailing list