[webkit-reviews] review requested: [Bug 12499] External <use> xlink:href references do not work : [Attachment 124547] Proposed patch

[bugzilla-daemon at webkit.org]

Renata Hodovan <reni at webkit.org> has asked  for review:
Bug 12499: External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Attachment 124547: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=124547&action=review

------- Additional Comments from Renata Hodovan <reni at webkit.org>
> > http://www.w3.org/2011/webappsec/
> > http://lists.w3.org/Archives/Public/public-webappsec/
> Is this already decided? Shall Reni post a mail here to ask which directive
to use?
In this patch I rate the cached SVG document to the image directive. Lack of
more precise source it's based on this conversation:
http://old.nabble.com/preventing-SVG-script-from-running-td30014840.html
 
> That can not happen. The external CachedSVGDocument is always cloned into the
target document, so if you script the shadow tree, or the <use> element it can
never affect the CachedSVGDocument. Reni will include a test for this.
Yeah, a dynamic update test is attached. This test refers the same source two
times via a use element. After an event (mouse click) the parent of the first
one will change, but the second remains the same.

>  > I'm not sure I understand.  The declaration says CachedSVGDocument* rather
than CachedResourceHandle<CachedSVGDocument>.
> She changed it locally I think :-)
Exactly! Sorry if I was ambiguous :)