[webkit-reviews] review granted: [Bug 61989] REGRESSION (r82580): Reproducible crash in CSSPrimitiveValue::computeLengthDouble : [Attachment 124539] Proposed Patch

Mon Jan 30 06:12:02 PST 2012

Simon Fraser (on vacation until 2-14) <simon.fraser at apple.com> has granted
Parag Radke <nrqv63 at motorola.com>'s request for review:
Bug 61989: REGRESSION (r82580): Reproducible crash in
CSSPrimitiveValue::computeLengthDouble
https://bugs.webkit.org/show_bug.cgi?id=61989

Attachment 124539: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=124539&action=review

------- Additional Comments from Simon Fraser (on vacation until 2-14)
<simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124539&action=review

> Source/WebCore/ChangeLog:9
> +	   of the root element.In this case as HTML element has a property
'hidden' and hence renderer is NULL

Space after . please.

> Source/WebCore/ChangeLog:12
> +	   Test: fast/css/bug61989-fontsize-unit-rems-crash.html

You don't really need the bug number in the filename.

> LayoutTests/fast/css/bug61989-fontsize-unit-rems-crash.html:1
> +<html hidden><title style="line-height: 1rem;">Test case for 61989</title>

The hidden attribute seems contentious
<http://peter.sh/2010/06/thoughts-on-the-html5-hidden-attribute/>

Does the bug still reproduce with display:none? That might be a better way to
test it.