[webkit-reviews] review granted: [Bug 77086] [GStreamer] 0.11 webkitwebsrc : [Attachment 124090] 0.11 webkitwebsrc

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 77086: [GStreamer] 0.11 webkitwebsrc
https://bugs.webkit.org/show_bug.cgi?id=77086

Attachment 124090: 0.11 webkitwebsrc
https://bugs.webkit.org/attachment.cgi?id=124090&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124090&action=review


Thanks Sebastian for the review! A couple nits + the error fix and this is good
to land.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:509
>      case GST_QUERY_DURATION:
> -    {
> -	   GstFormat format;
> +	   {
> +	       GstFormat format;

It's usual for these braces to be in the same line as the case statement, and
close on the same column as the c in case.

case BLA: {
    codegoeshere;
}

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:558
> +    static gchar* protocols[] = {(gchar*) "http", (gchar*) "https", 0 };

static_cast<>, I'd say let's not use the gchar defines unless it's necessary =)