[webkit-reviews] review granted: [Bug 76761] [BlackBerry] Credential backing store implementation : [Attachment 124484] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 76761: [BlackBerry] Credential backing store implementation
https://bugs.webkit.org/show_bug.cgi?id=76761

Attachment 124484: Patch
https://bugs.webkit.org/attachment.cgi?id=124484&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124484&action=review


it loosk good, r+

Please re-upload with the suggestions addressed if you think they are
convenient, and add "Reviewed by Antonio Gomes" to the new patch/changelog. No
need to another review round, only cq+ needed.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:70
> +	   // Create table logins

I would drop this comment. it looks unneeded given the line below it. Also
lacks a "." at the end :-)

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:74
> +	   // Create index for table logins

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:77
> +    } else { // Initiate CredentialStorage

. in the end