[webkit-reviews] review granted: [Bug 77186] [Chromium] REGRESSION(r87067): WebFrame::setFindEndstateFocusAndSelection() doesn't set the selection for <input> and <textarea> : [Attachment 124265] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 77186: [Chromium] REGRESSION(r87067):
WebFrame::setFindEndstateFocusAndSelection() doesn't set the selection for
<input> and <textarea>
https://bugs.webkit.org/show_bug.cgi?id=77186

Attachment 124265: Patch
https://bugs.webkit.org/attachment.cgi?id=124265&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
Looks OK. But having if (host->hasTagName(HTMLNames::inputTag) ||
host->hasTagName(HTMLNames::textareaTag)) looks cryptic a bit. Hopefully we can
give some intention revealing name for this kind of check.