[webkit-reviews] review denied: [Bug 77295] V8 idl code generator doesn't handle [CachedAttribute] on SerializedScriptValue attributes. : [Attachment 124462] Proof of concept patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 77295: V8 idl code generator doesn't handle [CachedAttribute] on
SerializedScriptValue attributes.
https://bugs.webkit.org/show_bug.cgi?id=77295

Attachment 124462: Proof of concept patch
https://bugs.webkit.org/attachment.cgi?id=124462&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124462&action=review


> Source/WebCore/Modules/intents/Intent.idl:34
> +	   readonly attribute [InitializedByConstructor] SerializedScriptValue
data;

You do not need to add [InitializedByConstructor] here. Sorry,
[InitializedByConstructor] is mis-renamed and it should be
[InitializedByEventConstructor]. It is used by Event constructors only (i.e.
[ConstructorTemplate=Event]). I'll rename it later.

Would you write a patch, ignoring [InitializedByConstructor] cases? Then, the
patch would become much simpler.