[webkit-reviews] review requested: [Bug 75387] Get GDB to display a proper backtrace through JITted functions : [Attachment 124434] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 28 01:43:35 PST 2012
Sanjoy Das <thedigitalangel at gmail.com> has asked for review:
Bug 75387: Get GDB to display a proper backtrace through JITted functions
https://bugs.webkit.org/show_bug.cgi?id=75387
Attachment 124434: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=124434&action=review
------- Additional Comments from Sanjoy Das <thedigitalangel at gmail.com>
The void * error has been fixed by adding proper casts.
Changed the __attribute__((noinline)) to NEVER_INLINE, so this should now work
on Windows.
jscplugin now uses scons, so it should build successfully on OSX. I don't have
access to an OSX installation so I could not test this completely, but it
builds and works as expected on Debian. I've used LoadableModule instead of
SharedLibrary, which I think is the correct method on OSX.
More information about the webkit-reviews
mailing list