[webkit-reviews] review granted: [Bug 76470] HRTFPanner could have high-quality mode for smoother transitions : [Attachment 124409] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 76470: HRTFPanner could have high-quality mode for smoother transitions
https://bugs.webkit.org/show_bug.cgi?id=76470

Attachment 124409: Patch
https://bugs.webkit.org/attachment.cgi?id=124409&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124409&action=review


Looks fine overall; a few minor nits which you can fix upon landing. r=me

> Source/WebCore/platform/audio/HRTFPanner.cpp:47
> +const int UnitializedAzimuth = -1;

Typo: should be Uninitialized.

> Source/WebCore/platform/audio/HRTFPanner.cpp:65
> +    , m_tempL1(128)

Please define and use a constant instead of the value 128. Could use it below
too.

> Source/WebCore/platform/audio/HRTFPanner.cpp:287
> +	       if (m_crossfadeIncr < 0 && fabs(m_crossfadeX) <
-m_crossfadeIncr) {

Could use an else if here.