[webkit-reviews] review granted: [Bug 77260] DRT pasteboard object should return the correct pasteboard name : [Attachment 124396] Pastch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Enrica Casucci <enrica at apple.com>'s request for
review:
Bug 77260: DRT pasteboard object should return the correct pasteboard name
https://bugs.webkit.org/show_bug.cgi?id=77260

Attachment 124396: Pastch
https://bugs.webkit.org/attachment.cgi?id=124396&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=124396&action=review


r=me assuming you fix the memory management issue.

> Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m:45
> +-(id)initWithName:(NSString*)name;

Needs a space before the *. A newline before this line wouldn’t hurt either.

> Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m:91
> +- (id)initWithName:(NSString*)name

Needs a space before the *.

> Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m:96
> +    pasteboardName = name;

You should -copy name here and -release pasteboardName in -dealloc.