[webkit-reviews] review requested: [Bug 73350] [chromium] Allow scrolling non-root layers in the compositor thread : [Attachment 124395] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 27 16:28:06 PST 2012


Sami Kyostila <skyostil at google.com> has asked  for review:
Bug 73350: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Attachment 124395: Patch
https://bugs.webkit.org/attachment.cgi?id=124395&action=review

------- Additional Comments from Sami Kyostila <skyostil at google.com>
 - Remove custom iterators in favor of layer iterators.
 - Move scrollBy() from LayerChromium to ContentLayerChromium.
 - Use LayerChromium instead of PlatformLayer in ChromeClientImpl.
 - The inverse screen space transform for a non-composited content layer does
not introduce page scale, so no need to undo it in isContentPointWithinLayer().
 - Add new tests for hit testing against a backfacing layer and a normal or
non-composited layer with page scaling.


More information about the webkit-reviews mailing list