[webkit-reviews] review granted: [Bug 77249] Get rid of TransformOperationList : [Attachment 124382] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 27 15:46:10 PST 2012


mitz at webkit.org has granted Chris Marrin <cmarrin at apple.com>'s request for
review:
Bug 77249: Get rid of TransformOperationList
https://bugs.webkit.org/show_bug.cgi?id=77249

Attachment 124382: Patch
https://bugs.webkit.org/attachment.cgi?id=124382&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=124382&action=review


> Source/WebCore/platform/graphics/GraphicsLayer.h:431
> +    static int validateTransformOperations(const KeyframeValueList&, bool&
hasBigRotation);

The patch looks fine but I wish the name of this function better explained what
its return value was. indexOfOperationsThatMatch() or some such.


More information about the webkit-reviews mailing list