[webkit-reviews] review denied: [Bug 71488] [CSSRegions]Add support for background-color in region styling : [Attachment 124329] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 27 13:03:05 PST 2012


Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 71488: [CSSRegions]Add support for background-color in region styling
https://bugs.webkit.org/show_bug.cgi?id=71488

Attachment 124329: Patch
https://bugs.webkit.org/attachment.cgi?id=124329&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Overall I like this approach. It seems kind of silly to waste 4 bytes in the
RenderBoxRegionInfo for the original style though. It seems like you could just
use a HashMap from RenderBox to RefPtr<RenderStyle> for that instead. Since
most of the time you're not going to have any region styling, it seems better
to avoid bloating RenderBoxRegionInfo in the common case.


More information about the webkit-reviews mailing list