[webkit-reviews] review granted: [Bug 75762] Pointer Lock: Implement pointer interface : [Attachment 124206] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Vincent Scheib
<scheib at chromium.org>'s request for review:
Bug 75762: Pointer Lock: Implement pointer interface
https://bugs.webkit.org/show_bug.cgi?id=75762

Attachment 124206: Patch
https://bugs.webkit.org/attachment.cgi?id=124206&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124206&action=review


> Source/WebCore/ChangeLog:21
> +	   Implement the navigator.pointer interface via a new
> +	   PointerLockController class, as per
> +	   http://dvcs.w3.org/hg/webevents/raw-file/default/mouse-lock.html.
> +
> +	   The implementation is being made in steps, the feature is still
behind
> +	   compile-time and run-time flags, 'webkit' prefixed, and not yet
enabled
> +	   in any browser. (Chromium has a developer flag required.) Follow-up
> +	   work will include handling DOM elements being removed, making all
> +	   callbacks asynchronous, iframe permissions (similar to Full Screen),

> +	   etc.
> +
> +	   PointerLockController maintains state of which Element is the
current
> +	   lock target and the success and failure callbacks. ChromeClient has
> +	   methods added to expose the required state change requests.

Thanks for filing in more details, that's very helpful!

> Source/WebCore/page/PointerLockController.cpp:46
> +PassOwnPtr<PointerLockController> PointerLockController::create(Page* page)
> +{
> +    return adoptPtr(new PointerLockController(page));
> +}

Nit: can be inlined in the class.