[webkit-reviews] review granted: [Bug 77212] [Qt] Spurious resize events from frameviews using fixed layout : [Attachment 124316] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Allan Sandfeld
Jensen <allan.jensen at nokia.com>'s request for review:
Bug 77212: [Qt] Spurious resize events from frameviews using fixed layout
https://bugs.webkit.org/show_bug.cgi?id=77212

Attachment 124316: Patch
https://bugs.webkit.org/attachment.cgi?id=124316&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=124316&action=review


> ChangeLog:9
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * ManualTests/resize-events.html: Added.
> +

A comment why a layout test wasnt possible would have been good

> ManualTests/resize-events.html:33
> +	       // 0 or 1 resize events are acceptable, more is not

Why not write this in the HTML, now it is a manual test? You could even make it
write SUCCESS/FAIL