[webkit-reviews] review granted: [Bug 76521] WebSocket: MessageEvent fired during send() on workers : [Attachment 122886] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 26 20:38:18 PST 2012


David Levin <levin at chromium.org> has granted  review:
Bug 76521: WebSocket: MessageEvent fired during send() on workers
https://bugs.webkit.org/show_bug.cgi?id=76521

Attachment 122886: Patch
https://bugs.webkit.org/attachment.cgi?id=122886&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122886&action=review


Thanks for the explanation. (I think I led you astray.)

> Source/WebCore/websockets/ThreadableWebSocketChannelClientWrapper.cpp:188
> +    if (m_suspended)

Since you are adding this check, perhaps in another patch (not this patch), you
could change the many places that do this


if (!m_suspended)
    processPendingTasks();

to

     processPendingTasks();


More information about the webkit-reviews mailing list