[webkit-reviews] review granted: [Bug 77177] Tools/Scripts/change-log-editor is broken due to $_ getting clobbered : [Attachment 124244] the patch

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 77177: Tools/Scripts/change-log-editor is broken due to $_ getting
clobbered
https://bugs.webkit.org/show_bug.cgi?id=77177

Attachment 124244: the patch
https://bugs.webkit.org/attachment.cgi?id=124244&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124244&action=review


> Tools/ChangeLog:3
> +	   Tools/Scripts/change-log-editor is broken due to $_ getting
clobbered

change-log-editor -> commit-log-editor

> Tools/Scripts/commit-log-editor:136
>  while (<LOG>) {
> +    my $curLine = $_;

You could do while (my $curLine = <LOG>) {

> Tools/Scripts/commit-log-editor:145
> +    if (!isGit() || $curLine =~ /^#/) { #

Could remove this EOL comment while you're here.