[webkit-reviews] review canceled: [Bug 76441] [Chromium] Cleanup of WebPopupMenuImpl : [Attachment 122741] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has canceled Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 76441: [Chromium] Cleanup of WebPopupMenuImpl
https://bugs.webkit.org/show_bug.cgi?id=76441

Attachment 122741: Patch
https://bugs.webkit.org/attachment.cgi?id=122741&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122741&action=review


>> Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:169
>> +	deref(); // Balances ref() from WebWidget::Create.
> 
> Where is WebWidget::Create? I couldn't find it.

Good catch!  It should be WebPopupMenu::create.

>> Source/WebKit/chromium/src/WebPopupMenuImpl.cpp:229
>> +	// FIXME: WebKit seems to always return false on mouse events methods.
For
> 
> FIXME (jcampan)?

Our style is FIXME without a name.
http://www.webkit.org/coding/coding-style.html#comments-fixme