[webkit-reviews] review granted: [Bug 45894] 3D transformed elements hide when showing the print dialog : [Attachment 123999] patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 45894: 3D transformed elements hide when showing the print dialog
https://bugs.webkit.org/show_bug.cgi?id=45894

Attachment 123999: patch
https://bugs.webkit.org/attachment.cgi?id=123999&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123999&action=review


r=me. Please file a bug to track fixing this in WebKit1 as well.

> Source/WebCore/ChangeLog:12
> +	   No new tests.

Please add a brief comment explaining why this isn't testable (no support for
setPrinting() in WKTR, etc.).

> Source/WebCore/platform/graphics/ca/LayerFlushScheduler.h:49
> +    bool isSuspended() { return m_isSuspended; }

I'd prefer this method to be const.