[webkit-reviews] review granted: [Bug 77161] Add API to get the parent frame in WKBundleFrameRef : [Attachment 124214] Implementation + test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 26 16:52:12 PST 2012
Anders Carlsson <andersca at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 77161: Add API to get the parent frame in WKBundleFrameRef
https://bugs.webkit.org/show_bug.cgi?id=77161
Attachment 124214: Implementation + test
https://bugs.webkit.org/attachment.cgi?id=124214&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=124214&action=review
> Tools/TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:64
> + assert(childFrame);
> + bool isParentFrameCheckSuccessful = childFrame ?
WKBundleFrameGetParentFrame(childFrame.get()) == frame : false;
You have both an assert and a null check here, do you really need the assert?
More information about the webkit-reviews
mailing list